Skip to content

OCPBUGS-114874: Document filtering oc adm top pod metrics by node - #119011

Open
Pratik-Redhat-Tech wants to merge 1 commit into
openshift:mainfrom
Pratik-Redhat-Tech:OCPBUGS-114874-top-pod-field-selector
Open

Pratik-Redhat-Tech wants to merge 1 commit into
openshift:mainfrom
Pratik-Redhat-Tech:OCPBUGS-114874-top-pod-field-selector

Conversation

@Pratik-Redhat-Tech

@Pratik-Redhat-Tech Pratik-Redhat-Tech commented Aug 28, 2026 •

Copy link
Copy Markdown

Version(s):
4.20+

Issue:
https://redhat.atlassian.net/browse/OCPBUGS-114874

Link to docs preview:

QE review:

  • QE has approved this change.

N/A — documentation example only.

Additional information:

Documents filtering oc adm top pod metrics by node using the existing --field-selector spec.nodeName=<node_name> flag. Does not add a new --node flag.

Fix: add example to OpenShift viewing pod usage statistics docs.

Add an --field-selector spec.nodeName example so users can find pod
usage on a node without a dedicated --node flag.

Signed-off-by: Pratik Langde <plangde@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 28, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-114874, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes OCPBUGS-114874

Document how to list pod CPU/memory usage on a specific node using the existing --field-selector flag:

oc adm top pod -A --field-selector spec.nodeName=<node_name>

This is not a new --node flag. Upstream kubernetes/kubernetes#141581 added --node and was closed because --field-selector spec.nodeName=... already covers that workflow (kubernetes/kubernetes#139107). This PR only adds the missing example so the existing flag is discoverable.

Signed-off-by: Pratik Langde plangde@redhat.com

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 28, 2026
@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2026
@openshift-ci

openshift-ci Bot commented Aug 28, 2026

Copy link
Copy Markdown

Hi @Pratik-Redhat-Tech. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 28, 2026
@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 28, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-114874, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

Could an OpenShift org member add /ok-to-test if this looks reasonable? This documents oc adm top pod --field-selector spec.nodeName=... for OCPBUGS-114874.

@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

Could an OpenShift org member add /ok-to-test if this looks reasonable? This documents oc adm top pod --field-selector spec.nodeName=... for OCPBUGS-114874.

@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-114874, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Fixes OCPBUGS-114874

Document how to list pod CPU/memory usage on a specific node using the existing --field-selector flag:

oc adm top pod -A --field-selector spec.nodeName=<node_name>

This is not a new --node flag. Upstream kubernetes/kubernetes#141581 added --node and was closed because --field-selector spec.nodeName=... already covers that workflow (kubernetes/kubernetes#139107). This PR only adds the missing example so the existing flag is discoverable.

Signed-off-by: Pratik Langde plangde@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

Hi, could an org member please run /ok-to-test when convenient? Thanks.

@abhatt-rh abhatt-rh changed the title OCPBUGS-114874: Document filtering oc adm top pod metrics by node OCPBUGS#114874: Document filtering oc adm top pod metrics by node Sep 7, 2026
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Fixes OCPBUGS-114874

Document how to list pod CPU/memory usage on a specific node using the existing --field-selector flag:

oc adm top pod -A --field-selector spec.nodeName=<node_name>

This is not a new --node flag. Upstream kubernetes/kubernetes#141581 added --node and was closed because --field-selector spec.nodeName=... already covers that workflow (kubernetes/kubernetes#139107). This PR only adds the missing example so the existing flag is discoverable.

Signed-off-by: Pratik Langde plangde@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abhatt-rh abhatt-rh added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 7, 2026
@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2026
@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown

@Pratik-Redhat-Tech: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz

Copy link
Copy Markdown
Contributor

@mburke5678 Can you help with this one?

@mburke5678

Copy link
Copy Markdown
Contributor

@arnaik@redhat.com Can you please assign a Node resource to review this suggested change?

@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 14, 2026
@Pratik-Redhat-Tech Pratik-Redhat-Tech changed the title OCPBUGS#114874: Document filtering oc adm top pod metrics by node OCPBUGS-114874: Document filtering oc adm top pod metrics by node Sep 22, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-114874, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Version(s):
4.20+

Issue:
https://redhat.atlassian.net/browse/OCPBUGS-114874

Link to docs preview:

QE review:

  • QE has approved this change.

N/A — documentation example only.

Additional information:

Documents filtering oc adm top pod metrics by node using the existing --field-selector spec.nodeName=<node_name> flag. Does not add a new --node flag.

Fix: add example to OpenShift viewing pod usage statistics docs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

Friendly follow-up: CI is green and ok-to-test is present. Updated the title to OCPBUGS-114874 for Jira linkage.

@ShaunaDiaz @mburke5678 — checking in on review assignment for this one. Happy to address any feedback. Thanks.

@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-114874, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Pratik-Redhat-Tech

Copy link
Copy Markdown
Author

CI is still green. The kubectl filter itself is already on openshift/kubernetes master (kubernetes#139107); this docs change is the OCP counterpart of the merged help example kubernetes#141656 and of openshift/kubernetes#2764 (OCPBUGS-113816). Happy to address review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants